refactor car store trackers #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
refactor/car-store
branch
from
993f50c
to
62d4723
Compare
dirkmc
force-pushed
the
refactor/car-store
branch
from
62d4723
to
c05a520
Compare
|
|
||
| if bs, ok := r.stores[key]; ok { | ||
| return bs, nil | ||
| } | ||
|
|
||
| return nil, xerrors.New("not found") | ||
| return nil, xerrors.Errorf("could not get blockstore for key %s: %w", ErrNotFound) |
There was a problem hiding this comment.
key isn't logged here.
|
|
||
| if bs, ok := r.stores[key]; ok { | ||
| return bs, nil | ||
| } | ||
|
|
||
| return nil, xerrors.New("not found") | ||
| return nil, xerrors.Errorf("could not get blockstore for key %s: %w", ErrNotFound) |
There was a problem hiding this comment.
key isn't logged here.
|
LGTM ! I'll fix the nits. |
aarshkshah1992
added a commit
that referenced
this pull request
Jul 13, 2021
* dag store lotus mount * storage client code complete-tests remain * storage miner first draft * second draft * provider state tests are now working * most unit tests working and more unit tests * refactor: car store trackers (#559) * Apply suggestions from code review Co-authored-by: dirkmc <dirkmdev@gmail.com> * nits and review * integration testing changes * storage test harness changes * added more TODOs * fix itests for storage * get offline deal tests working * tests work * more tests * integration tests * fix blockstore finalize * Integrate CARv2 blockstore in the retrieval market (#560) * refactor: integrate dag store into retrieval market * fix all tests and the padding issue * refactor: move mount from shared testutil to dagstore dir * refactor: add tests for lazy blockstore * refactor: code cleanup * feat: update go-car to latest * Dagstore lotus mount Implementation with tests (#564) * dagstore lotus mount impl * refactor: nicer error messages * mount api tests * refactor: integrate dag store (#565) Co-authored-by: Dirk McCormick <dirkmdev@gmail.com> * some storage market fixes by aarsh * fix: better error messages in DAG store wrapper * refactor: simplify mock dag store wrapper * fix: TestBounceConnectionDealTransferOngoing * refactor: remove some commented out code * refactor: closable blockstore interface to use full blockstore * fix: TestBounceConnectionDealTransferUnsealing * refactor: add comment explaining lotus mount template * test: verify that the lazy blockstore is only initialized once * fix: comment * fix: always finalize blockstore before reaching complete state (#567) Co-authored-by: aarshkshah1992 <aarshkshah1992@gmail.com> Co-authored-by: dirkmc <dirkmdev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.