Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Address review on the (CAR + DAGStore) work #577

Merged
merged 1 commit into from Jul 19, 2021

Conversation

aarshkshah1992
Copy link
Collaborator

No description provided.

@aarshkshah1992 aarshkshah1992 changed the base branch from master to feat/wip-markets-dagstore July 19, 2021 08:09
@aarshkshah1992 aarshkshah1992 marked this pull request as draft July 19, 2021 08:09
@codecov-commenter
Copy link

Codecov Report

Merging #577 (e1d8be9) into feat/wip-markets-dagstore (e6c3d53) will decrease coverage by 0.11%.
The diff coverage is 51.54%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##           feat/wip-markets-dagstore     #577      +/-   ##
=============================================================
- Coverage                      65.07%   64.97%   -0.10%     
=============================================================
  Files                             65       67       +2     
  Lines                           4531     4649     +118     
=============================================================
+ Hits                            2948     3020      +72     
- Misses                          1308     1342      +34     
- Partials                         275      287      +12     
Impacted Files Coverage Δ
dagstore/dagstorewrapper.go 0.00% <0.00%> (ø)
storagemarket/impl/client.go 21.56% <0.00%> (ø)
storagemarket/impl/client_environments.go 0.00% <0.00%> (ø)
storagemarket/impl/providerstates/provider_fsm.go 73.95% <ø> (ø)
storagemarket/types.go 85.37% <ø> (ø)
storagemarket/impl/provider_environments.go 9.38% <25.00%> (ø)
storagemarket/impl/provider.go 28.44% <50.00%> (+0.05%) ⬆️
storagemarket/impl/shardregistration.go 68.12% <68.12%> (ø)
filestorecaradapter/adapter.go 80.00% <80.00%> (ø)
storagemarket/impl/clientutils/clientutils.go 43.25% <83.34%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d8beae...e1d8be9. Read the comment docs.

Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dirkmc
Copy link
Contributor

dirkmc commented Jul 19, 2021

I think we can safely make changes by just adding commits to the original PR

@aarshkshah1992 aarshkshah1992 marked this pull request as ready for review July 19, 2021 08:27
@aarshkshah1992 aarshkshah1992 merged commit d96d8ea into feat/wip-markets-dagstore Jul 19, 2021
@aarshkshah1992 aarshkshah1992 deleted the feat/address-raulk-review branch July 19, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants