Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CARv2 library and address breaking changes #580

Merged
merged 1 commit into from Jul 20, 2021

Conversation

aarshkshah1992
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #580 (d5cb414) into feat/wip-markets-dagstore (746035a) will increase coverage by 0.18%.
The diff coverage is 66.67%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##           feat/wip-markets-dagstore     #580      +/-   ##
=============================================================
+ Coverage                      66.30%   66.48%   +0.18%     
=============================================================
  Files                             63       63              
  Lines                           4477     4477              
=============================================================
+ Hits                            2968     2976       +8     
+ Misses                          1228     1220       -8     
  Partials                         281      281              
Impacted Files Coverage Δ
storagemarket/impl/provider_environments.go 9.38% <33.34%> (ø)
carstore/read_only_blockstore.go 82.36% <100.00%> (ø)
filestorecaradapter/adapter.go 80.00% <100.00%> (ø)
...oragemarket/impl/providerstates/provider_states.go 86.22% <100.00%> (ø)
retrievalmarket/events.go 80.00% <0.00%> (+80.00%) ⬆️
retrievalmarket/dealstatus.go 80.00% <0.00%> (+80.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 746035a...d5cb414. Read the comment docs.

Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dirkmc dirkmc merged commit 3f44f43 into feat/wip-markets-dagstore Jul 20, 2021
@dirkmc dirkmc deleted the feat/update-carv2-readonly branch July 20, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants