New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace direct go-libp2p-core references with go-libp2p/core #777
replace direct go-libp2p-core references with go-libp2p/core #777
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #777 +/- ##
=======================================
Coverage 57.66% 57.66%
=======================================
Files 66 66
Lines 5564 5564
=======================================
Hits 3208 3208
Misses 2013 2013
Partials 343 343
|
@hannahhoward @dirkmc could i get a review please? |
@marten-seemann i dont have perms to merge, mind granting me if you can or merging this? |
@hannahhoward @marten-seemann @dirkmc pinging again to get help with merging since i dont have perms |
Making changes to go-fil-markets means we also need to make the same change in boost and lotus, then run a comprehensive test suite on both of those projects, so it's not a simple task. |
This PR doesn't bump any versions, so it shouldn't have any side effects on other repos. Or am I missing something? |
@dirkmc @hannahhoward Is there anything else needed to get this PR merged? |
@marten-seemann is the code at
exactly the same as the code at
? Same question for protocol, network, etc |
Yes, we moved go-libp2p-core into go-libp2p a while ago. |
Fixes #762