Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace direct go-libp2p-core references with go-libp2p/core #777

Merged

Conversation

neelvirdy
Copy link
Contributor

@neelvirdy neelvirdy commented Jan 24, 2023

Fixes #762

@codecov-commenter
Copy link

Codecov Report

Merging #777 (ded6810) into master (0fccfc9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #777   +/-   ##
=======================================
  Coverage   57.66%   57.66%           
=======================================
  Files          66       66           
  Lines        5564     5564           
=======================================
  Hits         3208     3208           
  Misses       2013     2013           
  Partials      343      343           
Impacted Files Coverage Δ
retrievalmarket/impl/client.go 71.05% <ø> (ø)
retrievalmarket/impl/clientstates/client_states.go 95.32% <ø> (ø)
retrievalmarket/impl/dtutils/dtutils.go 81.20% <ø> (ø)
retrievalmarket/impl/provider_environments.go 66.67% <ø> (ø)
...market/impl/requestvalidation/requestvalidation.go 80.19% <ø> (ø)
retrievalmarket/migrations/migrations.go 68.46% <ø> (ø)
retrievalmarket/network/libp2p_impl.go 84.91% <ø> (ø)
retrievalmarket/network/old_query_stream.go 77.15% <ø> (ø)
retrievalmarket/network/query_stream.go 60.00% <ø> (ø)
retrievalmarket/types.go 58.03% <ø> (ø)
... and 16 more

@neelvirdy
Copy link
Contributor Author

neelvirdy commented Jan 24, 2023

@hannahhoward @dirkmc could i get a review please?

go.mod Show resolved Hide resolved
@neelvirdy
Copy link
Contributor Author

@marten-seemann i dont have perms to merge, mind granting me if you can or merging this?

@neelvirdy
Copy link
Contributor Author

@hannahhoward @marten-seemann @dirkmc pinging again to get help with merging since i dont have perms

@dirkmc
Copy link
Contributor

dirkmc commented Jan 31, 2023

Making changes to go-fil-markets means we also need to make the same change in boost and lotus, then run a comprehensive test suite on both of those projects, so it's not a simple task.
Is there an urgent need to make this change?

@marten-seemann
Copy link
Contributor

Making changes to go-fil-markets means we also need to make the same change in boost and lotus, then run a comprehensive test suite on both of those projects, so it's not a simple task. Is there an urgent need to make this change?

This PR doesn't bump any versions, so it shouldn't have any side effects on other repos. Or am I missing something?

@marten-seemann
Copy link
Contributor

@dirkmc @hannahhoward Is there anything else needed to get this PR merged?

@dirkmc
Copy link
Contributor

dirkmc commented Feb 6, 2023

@marten-seemann is the code at

"github.com/libp2p/go-libp2p-core/peer"

exactly the same as the code at

"github.com/libp2p/go-libp2p/core/peer"

?

Same question for protocol, network, etc

@marten-seemann
Copy link
Contributor

marten-seemann commented Feb 6, 2023

Yes, we moved go-libp2p-core into go-libp2p a while ago.

@dirkmc dirkmc merged commit a96e387 into filecoin-project:master Feb 6, 2023
@neelvirdy neelvirdy deleted the nvirdy/no-more-go-libp2p-core branch February 24, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use libp2p/go-libp2p/core instead of legacy libp2p/go-libp2p-core
4 participants