Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore stream close error in ProposeDeal #793

Merged
merged 1 commit into from May 30, 2023

Conversation

magik6k
Copy link
Collaborator

@magik6k magik6k commented May 30, 2023

Fix for the errors observed in filecoin-project/lotus#10854

As far as I can tell this is the only place checking deal close errors

@magik6k magik6k force-pushed the fix/dealpropose-close-err branch from a0ff0f2 to 3f0a670 Compare May 30, 2023 13:46
Copy link
Collaborator

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable and safe to do

@magik6k magik6k merged commit 62ac6f5 into master May 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants