Feat/pork-swarm-follow-up-2382 #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosalinekarr
changed the title
phritz
approved these changes
Mar 21, 2019
rosalinekarr
force-pushed
the
feat/pork-swarm-follow-up-2382
branch
from
02ae226
to
b559c6c
Compare
ZenGround0
approved these changes
Mar 22, 2019
rosalinekarr
force-pushed
the
feat/pork-swarm-follow-up-2382
branch
from
b559c6c
to
4657bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
go-filecoin swarm connectstops after the first address to fail rather than trying other addresses.Solution
Change swarm connect to return a channel with errors and peer ids for each attempted connection.
Resolves #2382