refactor: rename node.Config to node.Builder #3400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icorderi
force-pushed
the
refactor/rename-node-builder
branch
from
ff59ab6
to
34d73aa
Compare
frrist
approved these changes
Sep 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #3400 +/- ##
======================================
- Coverage 47% 47% -1%
======================================
Files 228 228
Lines 14235 14235
======================================
- Hits 6815 6807 -8
- Misses 6418 6426 +8
Partials 1002 1002 |
anorth
reviewed
Sep 12, 2019
| @@ -37,7 +37,7 @@ func TestMessagePropagation(t *testing.T) { | |||
| // Initialize the first node to be the message sender. | |||
| senderNodeOpts := TestNodeOptions{ | |||
| GenesisFunc: genesis, | |||
| ConfigOpts: DefaultTestingConfig(), | |||
| BuilderOpts: DefaultTestingConfig(), | |||
There was a problem hiding this comment.
Can you rename DefaultTestingConfig in a follow-up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.