Introduce Stats API to expose valustore statistics
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose an API that, when supported by the backing store, it returns the number of unique multihashes stored. Implement stats calculation for pebble as an estimate of the number of entries in SST files when the key range falls with the multihash key start/end. Relates to: ipni/storetheindex#982
willscott
approved these changes
Nov 24, 2022
| // overwhelmingly larger than provider records. | ||
| if s.comparer.Compare(start.buf, info.Smallest.UserKey) <= 0 || | ||
| s.comparer.Compare(end.buf, info.Largest.UserKey) <= 0 { | ||
| stats.MultihashCount += info.Properties.NumEntries |
There was a problem hiding this comment.
do we have a sense of how expensive this is?
There was a problem hiding this comment.
It took 13 seconds to return on dido's snapshot from 2nd of Nov.
Expense here just means it might take time. It scans each of the SST files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose an API that, when supported by the backing store, it returns the number of unique multihashes stored.
Implement stats calculation for pebble as an estimate of the number of entries in SST files when the key range falls with the multihash key start/end.
Relates to: ipni/storetheindex#982