fix: correct error messages for http handler

pkg/server/http/ipfs_test.go

@@ -134,6 +134,14 @@ func TestIpfsHandler(t *testing.T) {
 			wantStatus: http.StatusBadRequest,
 			wantBody:   "invalid providers parameter\n",
 		},
+		{
+			name:       "400 on invalid entity-bytes query parameter",
+			method:     "GET",
+			path:       "/ipfs/bafybeic56z3yccnla3cutmvqsn5zy3g24muupcsjtoyp3pu5pm5amurjx4?entity-bytes=invalid",
+			headers:    map[string]string{"Accept": "application/vnd.ipld.car"},
+			wantStatus: http.StatusBadRequest,
+			wantBody:   "invalid entity-bytes parameter\n",
+		},
 		{
 			name:    "404 when no candidates can be found",
 			method:  "GET",

pkg/server/http/util.go

@@ -14,7 +14,11 @@ import (
 // parameter is not one of the supported values.
 func ParseScope(req *http.Request) (types.DagScope, error) {
 	if req.URL.Query().Has("dag-scope") {
-		return types.ParseDagScope(req.URL.Query().Get("dag-scope"))
+		if ds, err := types.ParseDagScope(req.URL.Query().Get("dag-scope")); err != nil {
+			return ds, errors.New("invalid dag-scope parameter")
+		} else {
+			return ds, nil
+		}
 	}
 	// check for legacy param name -- to do -- delete once we confirm this isn't used any more
 	if req.URL.Query().Has("car-scope") {
@@ -39,7 +43,7 @@ func ParseByteRange(req *http.Request) (*types.ByteRange, error) {
 	if req.URL.Query().Has("entity-bytes") {
 		br, err := types.ParseByteRange(req.URL.Query().Get("entity-bytes"))
 		if err != nil {
-			return nil, err
+			return nil, errors.New("invalid entity-bytes parameter")
 		}
 		return &br, nil
 	}