Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP RequestLogger should accept io.Writer #73

Open
kylehuntsman opened this issue Feb 7, 2023 · 1 comment
Open

HTTP RequestLogger should accept io.Writer #73

kylehuntsman opened this issue Feb 7, 2023 · 1 comment

Comments

@kylehuntsman
Copy link
Contributor

The RequestLogger in the IPFS Handler should accept an io.Writer to allow for writing out to places other than stdout. This probably comes through all the way from the daemon CLI through an output flag that accepts a file location? There's a bigger conversation here around logging possibly going to stderr while CLI output goes to stdout by default. The daemon output flag would control the CLI output in this case.

@rvagg
Copy link
Member

rvagg commented Sep 29, 2023

I have --log-file in frisbii for this, we should do the same with the daemon and it shouldn't be hard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants