Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the old event recorder #275

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

kylehuntsman
Copy link
Contributor

@kylehuntsman kylehuntsman commented May 31, 2023

Deletes the pkg/eventrecorder directory.

I'm not sure if we're using pkg/eventrecorder/filelogserver/, but I moved it into pkg/aggregateeventrecorder/ just in case one of us is. If it's testing something, then it should be moved to a test. If it's a utility, then maybe it should be internal? Maybe it's own package if it's useful for a Lassie user to have? The original context of it is lost on me.

Closes #273

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #275 (c0fbf61) into main (ac7d534) will increase coverage by 0.32%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   70.96%   71.28%   +0.32%     
==========================================
  Files          71       69       -2     
  Lines        6199     6043     -156     
==========================================
- Hits         4399     4308      -91     
+ Misses       1550     1491      -59     
+ Partials      250      244       -6     

see 10 files with indirect coverage changes

@kylehuntsman
Copy link
Contributor Author

Via @rvagg from Slack in reference to the filelogserver

delete it, without old events it’s useless, it was only useful in the beginning

@kylehuntsman kylehuntsman merged commit 4ed0ff7 into main May 31, 2023
16 checks passed
@kylehuntsman kylehuntsman deleted the fix/rm-old-event-recorder branch May 31, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old event recorder
3 participants