Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique http client for indexer #280

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

hannahhoward
Copy link
Collaborator

Goals

We have an inadvertent HTTP timeout for fetches from HTTP providers. It's because we share the HTTP default client with the indexer fetcher, and that sets a 1 minute timeout.

Implementation

  • Use a unique client with the indexer

dont use the default client with th eindexer, so the timeout used there is not propogated
@codecov-commenter
Copy link

Codecov Report

Merging #280 (29356ef) into main (9622d8b) will increase coverage by 0.38%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   71.25%   71.63%   +0.38%     
==========================================
  Files          70       70              
  Lines        6283     6283              
==========================================
+ Hits         4477     4501      +24     
+ Misses       1554     1540      -14     
+ Partials      252      242      -10     
Impacted Files Coverage Δ
pkg/lassie/lassie.go 61.15% <0.00%> (ø)

... and 6 files with indirect coverage changes

@hannahhoward hannahhoward merged commit 0b8163d into main Jun 5, 2023
16 checks passed
@hannahhoward hannahhoward deleted the fix/non-standard-client branch June 5, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants