Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: extra debug output for flaky failure case #292

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 6, 2023

The flaky tests in CI are a 504, which should mean it's coming out of here:

errorResponse(res, statusLogger, http.StatusGatewayTimeout, fmt.Errorf("failed to fetch CID: %w", err))

The body should contain the error message.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #292 (4f676c7) into main (2edae8b) will increase coverage by 0.14%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   72.52%   72.67%   +0.14%     
==========================================
  Files          68       68              
  Lines        6203     6203              
==========================================
+ Hits         4499     4508       +9     
+ Misses       1456     1450       -6     
+ Partials      248      245       -3     

see 7 files with indirect coverage changes

@rvagg
Copy link
Member Author

rvagg commented Jun 6, 2023

Notable failure in CI for this: https://github.com/filecoin-project/lassie/actions/runs/5187581762/jobs/9351133526?pr=292

Not quite the same issue, it's failing during retrieval and we're getting the mime type 0 error so it must be a mid-retrieval error we're not seeing.

@hannahhoward
Copy link
Collaborator

Ouch I thought we'd resolved that one :(

@rvagg rvagg merged commit fe9e760 into main Jun 6, 2023
14 of 16 checks passed
@rvagg rvagg deleted the rvagg/debug-flaky branch June 6, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants