feat: Add the state and code_cid for actors table #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terryhung
changed the title
birdychang
approved these changes
Apr 14, 2023
kasteph
reviewed
Apr 18, 2023
schemas/v1/20_actor_add_state.go
Outdated
|
|
||
| func init() { | ||
| patches.Register( | ||
| 20, |
There was a problem hiding this comment.
Suggested change
| 20, | |
| 21, |
Don't forget to rename the file as well from 20_actor_add_state.go to 21_actor_add_state.go
kasteph
approved these changes
Apr 18, 2023
Terryhung
force-pushed
the
terryhung/add-new-field-in-actors
branch
from
926eb74
to
554c126
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on the information provided, it appears that the
actor_statestable is being deprecated because the data it contains is mostly covered by theactorstable. However, there are two columns:stateandcode_cid, which are present inactor_statesbut missing inactors. To address this, these two columns will be added to theactorstable, thereby making theactor_statestable redundant. Once this is done, theactor_statestable can be safely deprecated.