feat: add new task for fevm trace #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terryhung
commented
Jun 2, 2023
tasks/fevm/vm/task.go
Outdated
| ActorCode: toActorCode, | ||
| Method: uint64(child.Message.Method), | ||
| Index: child.Index, | ||
| Params: base64.StdEncoding.EncodeToString(child.Message.Params), |
There was a problem hiding this comment.
Referring to the params value returned by lily chain getmessage, we also encode params value in Base64.
There was a problem hiding this comment.
what's the benefit to encode in base64?
There was a problem hiding this comment.
I think the one of reasons for encoding params into base64 is to ensure compatibility: Base64 encoding is a widely supported format, it is able to to mitigate risks across different operating systems and databases.
birdychang
reviewed
Jun 2, 2023
tasks/fevm/vm/task.go
Outdated
| ActorCode: toActorCode, | ||
| Method: uint64(child.Message.Method), | ||
| Index: child.Index, | ||
| Params: base64.StdEncoding.EncodeToString(child.Message.Params), |
There was a problem hiding this comment.
what's the benefit to encode in base64?
birdychang
reviewed
Jun 5, 2023
schemas/v1/26_fevm_traces.go
Outdated
| message_state_root TEXT, | ||
| transaction_hash TEXT, | ||
| message_cid TEXT, | ||
| trace_cid TEXT, |
tasks/fevm/trace/task.go
Outdated
| @@ -0,0 +1,199 @@ | |||
| package fevmvm | |||
tasks/fevm/trace/task.go
Outdated
| tasks "github.com/filecoin-project/lily/tasks" | ||
| ) | ||
|
|
||
| var log = logging.Logger("lily/tasks/fevmvm") |
tasks/fevm/trace/task.go
Outdated
Comment on lines
168
to
169
| Params: base64.StdEncoding.EncodeToString(child.Message.Params), | ||
| Returns: base64.StdEncoding.EncodeToString(child.Receipt.Return), |
There was a problem hiding this comment.
maybe use EthBytes to be consistent with eth?
Terryhung
changed the title
Terryhung
commented
Jun 7, 2023
tasks/fevm/trace/task.go
Outdated
| GasUsed: 0, | ||
| ExitCode: int64(child.Receipt.ExitCode), | ||
| ActorCode: toActorCode, | ||
| Method: uint64(child.Message.Method), |
There was a problem hiding this comment.
try to store readable method name
Terryhung
commented
Jun 7, 2023
tasks/fevm/trace/task.go
Outdated
| FromEthAddress: fromEthAddress, | ||
| ToEthAddress: toEthAddress, | ||
| Value: child.Message.Value.String(), | ||
| GasUsed: 0, |
Terryhung
force-pushed
the
terryhung/add-new-fevm-task-internal-transaction
branch
from
1b35296
to
33e7571
Compare
birdychang
approved these changes
Jun 7, 2023
added 2 commits
June 7, 2023 16:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.