Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change the splitstore setting in config and replace returning error with logging error in parsing vm_message #1246

Merged
merged 3 commits into from
Jul 25, 2023
Merged

feat: change the splitstore setting in config and replace returning error with logging error in parsing vm_message #1246

merged 3 commits into from
Jul 25, 2023

Conversation

Terryhung
Copy link
Collaborator

No description provided.

@Terryhung Terryhung marked this pull request as ready for review July 24, 2023 03:07
birdychang
birdychang approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@birdychang birdychang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update pr title?

@Terryhung Terryhung changed the title fix: change the splitstore config fix: change the splitstore setting in config and replace returning error with logging error in vm_message Jul 25, 2023
@Terryhung Terryhung changed the title fix: change the splitstore setting in config and replace returning error with logging error in vm_message fix: change the splitstore setting in config and replace returning error with logging error in parsing vm_message Jul 25, 2023
@Terryhung Terryhung changed the title fix: change the splitstore setting in config and replace returning error with logging error in parsing vm_message feat: change the splitstore setting in config and replace returning error with logging error in parsing vm_message Jul 25, 2023
@Terryhung Terryhung merged commit 6490d85 into master Jul 25, 2023
8 checks passed
@Terryhung Terryhung deleted the terryhung/fix-splitstore-config branch July 25, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birdychang birdychang birdychang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Terryhung @birdychang