Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lotus-fountain: make compatible with 0x addresses #10560

Closed
3 of 9 tasks
ognots opened this issue Mar 24, 2023 · 4 comments · Fixed by #10784
Closed
3 of 9 tasks

lotus-fountain: make compatible with 0x addresses #10560

ognots opened this issue Mar 24, 2023 · 4 comments · Fixed by #10784
Assignees
Labels
area/fvm kind/feature Kind: Feature need/team-input Hint: Needs Team Input P2 P2: Should be resolved

Comments

@ognots
Copy link
Contributor

ognots commented Mar 24, 2023

Checklist

  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated feature request to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus fvm/fevm - Lotus FVM and FEVM interactions
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt/WinningPoSt)
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

What is the motivation behind this feature request? Is your feature request related to a problem? Please describe.

make calibrationnet and other devnets FVM friendly, by making lotus-fountain compatible with 0x addresses.
this is necessary for the quick start tutorial to work as published

Describe the solution you'd like

Call EthAddressToFilecoinAddress when an 0x type address is detected in lotus-fountain's address field in the SENDING FUNDS section

Describe alternatives you've considered

No response

Additional context

No response

@TippyFlitsUK TippyFlitsUK added need/team-input Hint: Needs Team Input area/fvm P2 P2: Should be resolved and removed need/triage labels Apr 11, 2023
@ognots
Copy link
Contributor Author

ognots commented Apr 14, 2023

@maciejwitowski
Copy link
Contributor

maciejwitowski commented Apr 27, 2023

@ognots do you plan to work on it in the next weeks?

@maciejwitowski
Copy link
Contributor

Took a stab at implementing it #10784

@ognots
Copy link
Contributor Author

ognots commented May 1, 2023

Thanks @maciejwitowski this looks great. we'll still need a review from the lotus maintainers team. Let me know if you want me to escalate the priority of the review, this is a very important feature for the community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fvm kind/feature Kind: Feature need/team-input Hint: Needs Team Input P2 P2: Should be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants