Deprecated Linters Causing failed checks #11967
Comments
|
Some context, latest update turned deprecation of these into an error, see section 5 in https://golangci-lint.run/product/changelog/#1580 varcheck and deadcode recommended replacement with unused here: https://golangci-lint.run/product/changelog/#v1490 discussion on scopelint: golangci/golangci-lint#1041 - exportloopref and looppointer come up here, but looppointer was rejected @ golangci/golangci-lint#1924 revive mentioned as drop-in replacement to golint: https://golangci-lint.run/usage/linters/#revive unfortunately revive is quite a bit pickier than golint and throws up a bunch of errors when implementing, so we'll have to fix up a bunch of problems |
rvagg
added a commit
that referenced
this issue
May 7, 2024
|
#11968 an attempt at what it might take .. a lot, without global exclusions |
rvagg
added a commit
that referenced
this issue
May 9, 2024
rvagg
added a commit
that referenced
this issue
May 9, 2024
rvagg
added a commit
that referenced
this issue
May 13, 2024
rvagg
added a commit
that referenced
this issue
May 13, 2024
rjan90
pushed a commit
that referenced
this issue
May 24, 2024
magik6k
pushed a commit
to filecoin-project/curio
that referenced
this issue
May 26, 2024
magik6k
pushed a commit
to filecoin-project/curio
that referenced
this issue
May 27, 2024
magik6k
pushed a commit
to filecoin-project/curio
that referenced
this issue
May 27, 2024
magik6k
pushed a commit
to filecoin-project/curio
that referenced
this issue
May 27, 2024
rjan90
added a commit
that referenced
this issue
Jun 10, 2024
* release: v1.26.3 (#11908) (#11915) * deps: update dependencies to address migration memory bloat to address memory concerns during a heavy migration Ref: filecoin-project/go-state-types#260 Ref: whyrusleeping/cbor-gen#96 Ref: filecoin-project/go-amt-ipld#90 * release: prep v1.26.3 patch Prep v1.26.3 patch release: - Update changelog, version and make gen + make docsgen-cli * deps: update cbor-gen to tagged version deps: update cbor-gen to tagged version * deps: update go-state-types to tagged version deps: update go-state-types to tagged version v0.13.2 * chore: deps: update go-state-types to v0.13.3 Fixes a panic when we have fewer than 1k proposals. --------- Co-authored-by: Rod Vagg <rod@vagg.org> Co-authored-by: Steven Allen <steven@stebalien.com> * build: release: v1.27.0-rc1 (#11947) * chore: Set version as v1.27.0-rc1 Set version as v1.27.0-rc1, run make gen & make docsgen-cli * Update changelog Update changelog * Update changelog Update changelog based on feedback * Bump pubsub-dep Bump pubsub-dep * Prep v1.27.0-rc2 Prep v1.27.0-rc2 * Typo fixes, and more changelog updates Typo fixes, and more changelog updates * chore: remove unmaintained bootstrappers (#11983) * chore: remove unmaintained bootstrappers chore: remove unmaintained bootstrappers * Update mainnet.pi fixing typoed domain fixing typo for 1475.io 'bootstarp' -> 'bootstrap' * Update mainnet.pi apparently the actual hostname is typoed. so bootstarp it is. --------- Co-authored-by: smagdali <stefan@fil.org> * chore: update go-data-transfer and go-graphsync * add ETH addrs API to Gateway (#11979) * fix: copy Flags field from SectorOnChainInfo Fixes: #11962 * feat: libp2p: Lotus stream cleanup (#11993) * set stream deadlines in Lotus * reduce timeout * whitelist bootstrappers * fix tests * Update changelog and version Update changelog and version * ci: deprecate circle ci in favour of github actions (#11786) * Update changelog Update changelog with the deprecate circle-ci * chore: update drand (#12021) * Update changelog / make docsgen Update changelog / make docsgen * chore: lint: update golangci lint config * remove and replace some linters * remove some exclusions * make all exclusions more explicit matches * chore: lint: fix lint errors with new linting config Ref: #11967 * chore: lint: address feedback from reviews * doc: eth: restore comment lost in linter cleanup Ref: #11968 * chore: libp2p: update to v0.34.1 (#12027) * update libp2p to v0.34.0 * fix libp2p err * fix imports * update go mod * update go mod * Update changelog Update changelog * go mod tidy go mod tidy * revert go version change (#12050) * Update changelog Update changelog * chore: backport #12054 to release/v1.27.0 branch (#12056) * chore: pin golanglint-ci to v1.58.2 (#12054) Fixes: #12044 * Add backport to changelog Add backport to changelog --------- Co-authored-by: Rod Vagg <rod@vagg.org> * Fix where #12054 is placed in changelog Fix where #12054 is placed in changelog * Add trailing line in Makefile Add trailing line in Makefile * Go mod tidy Go mod tidy --------- Co-authored-by: Rod Vagg <rod@vagg.org> Co-authored-by: Steven Allen <steven@stebalien.com> Co-authored-by: smagdali <stefan@fil.org> Co-authored-by: Aarsh Shah <aarshkshah1992@gmail.com> Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
During the execution of golangci-lint when submitting a PR, several linters are reported as deprecated and fully inactivated, causing the process to fail. It suggest that we:
varcheckwithunused.deadcodewithunused.scopelintwithexportloopref.golintwithrevive.The text was updated successfully, but these errors were encountered: