Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRF tickets should be a chain #2778

Closed
nicola opened this issue Aug 3, 2020 · 4 comments · Fixed by #3510
Closed

VRF tickets should be a chain #2778

nicola opened this issue Aug 3, 2020 · 4 comments · Fixed by #3510
Labels
P0 P0: Critical Blocker

Comments

@nicola
Copy link

nicola commented Aug 3, 2020

We are still working on this.

The current ticket does not use the ticket from the previous epoch as input.

This means that the ticket chain is not "specific" to a chain anymore. This has implications on the validity of SealRandomness.

@nicola nicola changed the title VRF tickets should be a chain WIP: VRF tickets should be a chain Aug 3, 2020
@nicola
Copy link
Author

nicola commented Aug 4, 2020

We should not do this since this would make the ticket for leader election grindable. We can only do this if we have a separate ticket chain (hence a second VRF).

This has implications and we should discuss this in the next dev meeting.

We currently have two VRFs one is the electionProof one is the ticket. The ticket must have as input drand and the previous ticket, the electionProof only drand.

Currently the electionProof is correct, but the ticket is not

@nicola nicola changed the title WIP: VRF tickets should be a chain VRF tickets should be a chain Aug 4, 2020
@daviddias daviddias added the P0 P0: Critical Blocker label Aug 26, 2020
@nikkolasg
Copy link
Contributor

Currently computing a ticket takes the previous ticket only if there are no new drand entry in the block !

  • this code computes the ticket with a boolean haveNewEntries. Only if it is false, it adds the previous ticket to the drawing randomness logic
  • That flag is given here and is true when there are new drand entry to include in the new block.

Basically, with drand frequency = filecoin frequency, it seems like the previous ticket is never used ?

@nicola
Copy link
Author

nicola commented Sep 3, 2020

Working on a PR: #3510

@arajasek
Copy link
Contributor

arajasek commented Nov 6, 2020

Fixed by #3510

@arajasek arajasek closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 P0: Critical Blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants