Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli: error if backup file already exists #10209

Merged
merged 2 commits into from Feb 9, 2023
Merged

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Feb 8, 2023

Related Issues

fix #7028

Proposed Changes

Calling lotus-miner backup or lotus backup on a backup file which already exists corrupts the file.
Added check to see if a file with the same name already exists, and if it does error out explaining that another file name should be used.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Error out if backup file already exists
@rjan90 rjan90 marked this pull request as ready for review February 8, 2023 13:00
@rjan90 rjan90 requested a review from a team as a code owner February 8, 2023 13:00
cli/backup.go Outdated Show resolved Hide resolved
@magik6k magik6k self-requested a review February 9, 2023 15:48
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
@rjan90 rjan90 merged commit 9848e04 into master Feb 9, 2023
@rjan90 rjan90 deleted the fix-check-backupfile branch February 9, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling lotus-miner backup twice with the same output path corrupts the backup file
2 participants