feat: stmgr: cache migrated stateroots #10282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisperson
force-pushed
the
feat/cache-migrated-stateroot
branch
from
db2eede
to
0859ecf
Compare
travisperson
commented
Feb 16, 2023
travisperson
force-pushed
the
feat/cache-migrated-stateroot
branch
5 times, most recently
from
2cc16e4
to
a390d75
Compare
travisperson
force-pushed
the
feat/cache-migrated-stateroot
branch
3 times, most recently
from
b8901ef
to
01cb869
Compare
travisperson
force-pushed
the
feat/cache-migrated-stateroot
branch
from
01cb869
to
9c0563f
Compare
travisperson
force-pushed
the
feat/cache-migrated-stateroot
branch
from
9c0563f
to
814c146
Compare
travisperson
commented
Mar 1, 2023
| ) | ||
|
|
||
| func StateManager(lc fx.Lifecycle, cs *store.ChainStore, exec stmgr.Executor, sys vm.SyscallBuilder, us stmgr.UpgradeSchedule, b beacon.Schedule) (*stmgr.StateManager, error) { | ||
| sm, err := stmgr.NewStateManager(cs, exec, sys, us, b) |
There was a problem hiding this comment.
There are a lot of some one-line changes, this is an important one.
Stebalien
reviewed
Mar 2, 2023
Stebalien
reviewed
Mar 8, 2023
travisperson
force-pushed
the
feat/cache-migrated-stateroot
branch
from
be5f530
to
b4e589a
Compare
Stebalien
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#10048
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps