Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: worker: Ensure tempdir exists on startup #10433

Merged
merged 1 commit into from
May 3, 2023

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 9, 2023

Related Issues

This is something I occasionally run into in my setup when starting workers with custom TMPDIR, which on some of my systems disappears after reboot.

If not caught this would cause tasks like AddPiece to fail with a somewhat crypic error like

Caused by:
    0: failed to create data store
    1: No such file or directory (os error 2)

Proposed Changes

Make UX slightly better when the tempdir doesn't exist.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner March 9, 2023 09:06
@shrenujbansal
Copy link
Contributor

Where do we have cleanup for this temp dir?

@fridrik01
Copy link
Contributor

Where do we have cleanup for this temp dir?

I don't think we need to as this is simply making sure that future calls to os.TempDir() will not fail when overriding $TMPDIR.

Copy link
Contributor

@fridrik01 fridrik01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrenujbansal shrenujbansal merged commit 3ff8a09 into master May 3, 2023
@shrenujbansal shrenujbansal deleted the feat/worker-mktempdir branch May 3, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants