Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Eth RPC: do not occlude block param errors. #10534

Merged
merged 1 commit into from
May 8, 2023

Conversation

raulk
Copy link
Member

@raulk raulk commented Mar 22, 2023

Related Issues

RPC methods do not relay the error returned from parseBlkParam. This behaviour loses information and complicates debugging.

Proposed Changes

Wrap the error and make the error string more general since the problem may not be caused by parsing only.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • [] New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@raulk raulk requested a review from a team as a code owner March 22, 2023 11:39
@maciejwitowski
Copy link
Contributor

@raulk this looks good, can you merge this?

@jennijuju
Copy link
Member

@raulk this looks good, can you merge this?

Can’t until a lotus maintainer reviews this 😜

@ZenGround0 ZenGround0 merged commit ed7d1ef into master May 8, 2023
@ZenGround0 ZenGround0 deleted the raulk/fix-parse-block-param-error branch May 8, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants