Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: export-range: Ignore ipld Blocks not found in Receipts. #10535

Merged
merged 4 commits into from
Mar 28, 2023

Conversation

hsanjuan
Copy link
Contributor

@hsanjuan hsanjuan commented Mar 22, 2023

Related Issues

#10492

Proposed Changes

These commits improve error reporting during export-range so that users can easily pinpoint in which epoch and in which part of the export an error happens (particularly getting an error when reading a block to export).

Additionally, given there are references to never-written CIDs in Receipts (see linked issue), rather than aborting the export, it will just print a warning when these are found. This is less strict than decoding receipts and only skipping EventRoot CIDs, but possibly achieves the same result without the complexity.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@hsanjuan hsanjuan requested a review from Stebalien March 22, 2023 14:24
@hsanjuan hsanjuan self-assigned this Mar 22, 2023
@hsanjuan hsanjuan requested a review from a team as a code owner March 22, 2023 14:24
@hsanjuan hsanjuan changed the title Export-range: Ignore ipld Blocks not found in Receipts. Fix: export-range: Ignore ipld Blocks not found in Receipts. Mar 22, 2023
chain/store/snapshot.go Outdated Show resolved Hide resolved
@arajasek arajasek merged commit 4b2e74a into filecoin-project:master Mar 28, 2023
@hsanjuan hsanjuan deleted the filcryo-v1.20.0-branch branch March 28, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants