feat: populate the index on snapshot import #10556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridrik01
force-pushed
the
10537-populate-index-after-snapshot
branch
from
92891df
to
51b3ec4
Compare
fridrik01
force-pushed
the
10537-populate-index-after-snapshot
branch
from
51b3ec4
to
59640a8
Compare
fridrik01
commented
Mar 24, 2023
fridrik01
changed the title
vyzo
reviewed
Mar 24, 2023
chain/index/msgindex.go
Outdated
|
|
||
| dbPath := path.Join(basePath, dbName) | ||
| if _, err := os.Stat(dbPath); err == nil { | ||
| return xerrors.Errorf("msgindex already exists at %s", dbPath) |
There was a problem hiding this comment.
maybe just delete it and recreate it?
Sounds like the right thing to do.
fridrik01
force-pushed
the
10537-populate-index-after-snapshot
branch
from
e757030
to
b8137f6
Compare
|
@vyzo I double checked and verified that the lotus daemon continues to populate and update the |
vyzo
approved these changes
Mar 28, 2023
arajasek
approved these changes
Mar 28, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes: #10537
Proposed Changes
After importing from snapshot this PR creates and populates the sqlite message index introduced in #10452 from the 2k tipsets in the snapshot.
Additional Info
When loading from snapshot from mainnet, populating the message index takex approx 30 seconds. We should be able to lower this somewhat with bulk inserts (though doing it inside a transaction is at least an order of magnitude faster than not).
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps