Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proving: Initialize slice with with same length as partition #10569

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Mar 27, 2023

Related Issues

Fixes #10564

Proposed Changes

Initialize the postParam.Partitions slice with the same length as i.Partitions before iterating over it in the loop.

Additional Info

Tested on a local net, and now it does not panic:

lotus-miner proving compute window-post 0
Took 1.781950251s
[
  {
    "Deadline": 0,
    "Partitions": [
      {
        "Index": 0,
        "Skipped": []
      }
    ],
    "Proofs": [
      {
        "PoStProof": 5,
        "ProofBytes": "jTEZNQZRWjBRcpnOjyae10RtXnN0k8ALGYeenRLVpzdtBKTQiC+BdVlWdk1qehfarXYYWNE+ib9arhYRj4bmVnyA1xAOlLTzs81lEgW64g1tUOxTVaoBWj0sTPBQGEgbFsMB1vKrVkzBRkTUZU9ZWgaZYb59znxB7/ZrARVJw93hLwd3NRjZQvWNhj/JxfyVgaTuW9Uid2Hc2qIpoDrgKY9HRIQmmKTR9sSjYA3seX6B/6uBDI+/BoqaGJkOcOJc"
      }
    ],
    "ChainCommitEpoch": 0,
    "ChainCommitRand": null
  }
]

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Initialize the postParam.Partitions slice with the same length as i.Partitions before iterating over it in the loop.
@rjan90 rjan90 requested a review from a team as a code owner March 27, 2023 08:06
@rjan90 rjan90 changed the title fix: cli: Initialize slice with with same length as partition fix: proving: Initialize slice with with same length as partition Mar 27, 2023
@magik6k magik6k merged commit 2120fae into master Mar 27, 2023
@magik6k magik6k deleted the fix/panic-index-oor branch March 27, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lotus-miner proving compute window-post cmd panics with index out of range
3 participants