feat: Make execution trace configurable via env variable #10585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to make the execution trace cache size configurable as SPs may want to disable it while exchanges may want to crank it up. We were also are going with intuition for this value, so having ability to change it without a new build would help. Fixes: #10584
vyzo
reviewed
Mar 29, 2023
arajasek
approved these changes
May 4, 2023
| @@ -74,6 +75,17 @@ func (m *migrationResultCache) keyForMigration(root cid.Cid) dstore.Key { | |||
| return dstore.NewKey(kStr) | |||
| } | |||
|
|
|||
| func init() { | |||
| if s := os.Getenv("LOTUS_EXEC_TRACE_CACHE"); s != "" { | |||
There was a problem hiding this comment.
Rename to LOTUS_EXEC_TRACE_CACHE_SIZE
| @@ -40,8 +42,7 @@ import ( | |||
| const LookbackNoLimit = api.LookbackNoLimit | |||
| const ReceiptAmtBitwidth = 3 | |||
|
|
|||
| const execTraceCacheSize = 16 | |||
|
|
|||
| var defaultExecTraceCacheSize = 16 | |||
There was a problem hiding this comment.
Keep the old name? Because if the envvar is set, we set this field, which means it's no longer a default size?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#10584
#10504
Proposed Changes
We want to make the execution trace cache size configurable as SPs may want to disable it while exchanges may want to crank it up.
We were also are going with intuition for this value, so having ability to change it without a new build would help.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps