fix: log: Stop logging file does not exists

[rjan90]

Related Issues

fixes: #9073

Proposed Changes

Do not log 'file does not exist' errors when retrieving disk usage information. These errors are expected, as storage can be reserved before any files are written, and they were cluttering the logs unnecessarily.

Checklist

Before you mark the PR ready for review, please make sure that:

• Commits have a clear commit message.
• PR title is in the form of of <PR type>: <area>: <change being made>
  • example: fix: mempool: Introduce a cache for valid signatures
  • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
  • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
• New features have usage guidelines and / or documentation updates in
  • Lotus Documentation
  • Discussion Tutorials
• Tests exist for new functionality or change in behavior
• CI is green

[arajasek]

Maybe still debug-log the IsNotExist error?

[rjan90]

Based on the this code (the not cached part of the code) it seems like we actually do not care:

lotus/storage/paths/local.go

Lines 83 to 91 in a999469

	if err != nil {
	// we don't care about 'not exist' errors, as storage can be
	// reserved before any files are written, so this error is not
	// unexpected
	if !os.IsNotExist(err) {
	log.Warnf("getting disk usage of '%s': %+v", p.sectorPath(id, fileType), err)
	}
	continue
	}

I think the reason for it, is that it can take quite a bit of time between the sector being reserved, and the file being transferred over.

I can add the same comment to this part of the code as well?

[rjan90]

It also seems from my testing that the defualt logging setting for stores is DEBUG, which makes this logging a bit unbearable. I will look into tuning that down in another PR.