Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli: Check if the sectorID exists before removing #10611

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Apr 3, 2023

Related Issues

fixes: #6344

Proposed Changes

Check if the sector exists before running SectorRemove, and error out if the SectorID has not been created to prevent issues where the user removes the state for a non existing sectors

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Check if the sector exists before running `SectorRemove`, and error out if the SectorID has not bee created.
@rjan90 rjan90 marked this pull request as ready for review April 3, 2023 13:02
@rjan90 rjan90 requested a review from a team as a code owner April 3, 2023 13:02
@magik6k magik6k merged commit 4394187 into master Apr 4, 2023
@magik6k magik6k deleted the fix/check-sector-exists branch April 4, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lotus-miner sectors remove saves state for non existing sectors
2 participants