Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api: Add API and CLI to unseal sector #10626

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

shrenujbansal
Copy link
Contributor

@shrenujbansal shrenujbansal commented Apr 5, 2023

Related Issues

#5436

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@shrenujbansal shrenujbansal requested a review from a team as a code owner April 5, 2023 16:26
@shrenujbansal shrenujbansal changed the title Add API and CLI to unseal sector feat: api: Add API and CLI to unseal sector Apr 5, 2023
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I have a feeling this TODO might now be useful to implement and then create a CLI flag for, maybe in a follow up issue

@rjan90
Copy link
Contributor

rjan90 commented Apr 6, 2023

Worked well on a local devnet, will scale up and do some rounds on 32GiB sectors with real data.

Deal sector in sector 1:

lotus-miner sectors list
ID   State    OnChain  Active  Expiration                     Deals  DealWeight  VerifiedPower  
0    Proving  YES      YES     1550097 (in 10 weeks 8 hours)  CC                                
1    Proving  YES      YES     1550097 (in 10 weeks 8 hours)  1      2KiB        18KiB      

No unsealed sector:

lotus-miner storage find 1
In 94f8a49e-1208-442d-b960-9c6fca5ec2a0 (Sealed, Cache)
        Sealing: true; Storage: true
        Local (/root/.lotus-miner-local-net)
        URL: http://127.0.0.1:2345/remote/sealed/s-t01000-2

Then execute: lotus-miner sectors unseal 1

lotus-miner storage find 1
In 94f8a49e-1208-442d-b960-9c6fca5ec2a0 (Unsealed)
        Sealing: true; Storage: true
        Local (/root/.lotus-miner-local-net)
        URL: http://127.0.0.1:2345/remote/unsealed/s-t01000-1
In cefc9816-79fc-4884-84d4-eb1b6cedf697 (Sealed, Cache)
        Sealing: false; Storage: false
        Local (/root/.genesis-sectors)
        URL: http://127.0.0.1:2345/remote/sealed/s-t01000-1

@shrenujbansal
Copy link
Contributor Author

I have a feeling this TODO might now be useful to implement and then create a CLI flag for, maybe in a follow up issue

@ZenGround0 I think this requires a bit of thought as to where we'd want to move the unsealed sector too. Don't wanna gate this PR on that

@shrenujbansal shrenujbansal merged commit 0befed7 into master Apr 17, 2023
@shrenujbansal shrenujbansal deleted the sbansal/add-unseal-cli branch April 17, 2023 16:12
@rjan90 rjan90 linked an issue Apr 20, 2023 that may be closed by this pull request
@rjan90 rjan90 mentioned this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] - Manually generate unsealed sector
3 participants