Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include extra messages in ComputeState InvocResult output #10628

Merged
merged 1 commit into from
May 29, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Apr 5, 2023

Related Issues

ComputeState's InvocResult return currently only includes results for messages that were included in the base tipset. Any "extra" messages supplied don't show up in the return.

Proposed Changes

Include results for any extra messages supplied, even though most callers don't actually supply any.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner April 5, 2023 19:27
@arajasek arajasek force-pushed the asr/exec-trace-compute branch 2 times, most recently from 353bc07 to 7710a57 Compare April 5, 2023 19:56
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@arajasek arajasek merged commit 867a7b1 into master May 29, 2023
@arajasek arajasek deleted the asr/exec-trace-compute branch May 29, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants