Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: daemon: Auto-resume interrupted snapshot imports #10636

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 7, 2023

Related Issues

Closes #10618

Proposed Changes

Additional Info

Happens a lot on my internet, and was starting to get really annoying

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner April 7, 2023 15:45
lib/httpreader/resumable.go Outdated Show resolved Hide resolved
@magik6k magik6k force-pushed the feat/snapimport-resume branch 2 times, most recently from c75df7e to 82909b2 Compare April 25, 2023 09:29
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality will be very nice

Skimmed and looks good but my HTTP is pretty bad so not high confidence. I'm guessing you've already run this on a node, if not that would be very good to do before merging.

@magik6k
Copy link
Contributor Author

magik6k commented Apr 25, 2023

Yeah, already tested quite extensively with some bad internet

@magik6k magik6k merged commit 1e04ccb into master Apr 25, 2023
90 of 92 checks passed
@magik6k magik6k deleted the feat/snapimport-resume branch April 25, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot import occasionally fails with "..failed to read from underlying reader.."
2 participants