Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sealing: Split PCA/PCB batches if gas used exceeds block limit #10647

Merged
merged 7 commits into from
Apr 21, 2023
Merged

feat: sealing: Split PCA/PCB batches if gas used exceeds block limit #10647

merged 7 commits into from
Apr 21, 2023

Conversation

shrenujbansal
Copy link
Contributor

@shrenujbansal shrenujbansal commented Apr 10, 2023 •
edited

Related Issues

#10612

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@shrenujbansal shrenujbansal requested a review from a team as a code owner April 10, 2023 19:24
@shrenujbansal shrenujbansal changed the title Split precommit batches if gas used exceeds block limit feat: sealing: Split PCA/PCB batches if gas used exceeds block limit Apr 12, 2023
magik6k
magik6k reviewed Apr 13, 2023
View reviewed changes
node/impl/full/gas.go Outdated Show resolved Hide resolved
storage/pipeline/commit_batch.go Show resolved Hide resolved
storage/pipeline/commit_batch.go Outdated Show resolved Hide resolved
storage/pipeline/commit_batch.go Show resolved Hide resolved
@rjan90 rjan90 linked an issue Apr 20, 2023 that may be closed by this pull request
MaxCommitBatch/ MaxPreCommitBatch is too high #10612
Closed
magik6k
magik6k approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ideally we'd prove that it works in a real setup, outside of tests.

@magik6k magik6k merged commit b44ae9a into master Apr 21, 2023
@magik6k magik6k deleted the sbansal/split-pcb branch April 21, 2023 16:30
@rjan90 rjan90 mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Lotus-Miner-V2
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MaxCommitBatch/ MaxPreCommitBatch is too high
2 participants
@shrenujbansal @magik6k