Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storage: Remove temp fetching files after failed fetch #10661

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 12, 2023

Related Issues

Proposed Changes

This fixes an issue where partially fetched files would be left in fetching directories when the fetch operation failed, with logs like this:

fetch error http://10.99.16.4:3456/remote/cache/s-t02620-5917 (storage 86f06f35-dee0-405b-8c60-e508a35b5a2e) -> /data/3/store/cache/fetching/s-t02620-5917: write /data/3/store/cache/fetching/s-t02620-5917/sc-02-data-layer-7.dat: no space left on device

Additional Info

Should result with far less garbage data after fetch operations fail. Should also make the experience of running out of disk space while sealing much better.

  • Test that it works

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner April 12, 2023 23:13
@magik6k magik6k force-pushed the fix/cleanup-temp-failed-fetch branch from 5b0eafa to 7a4f697 Compare April 13, 2023 00:00
@magik6k magik6k merged commit 7e34b49 into master Apr 25, 2023
@magik6k magik6k deleted the fix/cleanup-temp-failed-fetch branch April 25, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants