Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tvx: make extract-multiple support the FVM #10714

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Conversation

Stebalien
Copy link
Member

Proposed Changes

  1. Fix flushing to handle the case where the VM is an FVM.
  2. Fix extract-multiple's code CID conversion.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • CI is green

@Stebalien Stebalien requested a review from a team as a code owner April 20, 2023 23:03
@Stebalien Stebalien requested review from ZenGround0 and shrenujbansal and removed request for ZenGround0 April 21, 2023 20:55
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little bit of a "if you tell me it works, I ✔️" review, but it does seem reasonable.

@arajasek arajasek merged commit cf85875 into master Apr 26, 2023
@arajasek arajasek deleted the fix/tvx-post-fvm branch April 26, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants