Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shed: migrations: add reminder about continuity testing tool #10762

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

arajasek
Copy link
Contributor

Related Issues

We didn't remember to run this tool in time for the nv19 upgrade. We should add this to our network upgrade testing checklist.

Proposed Changes

But also add a reminder in code :P

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner April 26, 2023 13:51
@jennijuju
Copy link
Member

jennijuju commented Apr 26, 2023

Description is a “lie”! We did!! Asked our friend @raulk help on Apr 18th!

But don’t mind additional reminders and team wide awareness

@arajasek arajasek merged commit 2af8b6e into master Apr 26, 2023
91 of 92 checks passed
@arajasek arajasek deleted the asr/add-reminder branch April 26, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants