feat: eth: Add support for blockHash param in eth_getLogs #10782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10781
Context
When working on #10780 I noticed we currently did not support the
blockHash
param for theeth_getLogs
rpc method. If it was specified by user he got confusing results (fromBlock/toBlock were both 0). This PR therefore adds this feature as described in the eth docsTest plan
Lets consider the tipset 2848101 (hex: 0x2B7565) and get the logs for only that tipset (using fromBlock/toBlock). Since the log output it long lets just count the lines and compute the sha1sum:
Now lets get the same tipset by specifying its blockHash and observe that we get the same results (since using blockHash is the same as specifying fromBlock=toBlock of the tipset):