Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli: Change arg wording in change-beneficiary cmd #10823

Merged
merged 1 commit into from
May 4, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented May 4, 2023

Proposed Changes

Change arg wording from minerAddress to minerID in the lotus-miner actor confirm-change-beneficiary and lotus-shed actor confirm-change-beneficiary cmds.

Additional Info

A user encountered some confusion when using the lotus-miner actor confirm-change-beneficiary cmd, as the args (minerAddress) input in the helptext can easily be confused with the owner address/key/.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Change arg from minerAddress to minerID
@rjan90 rjan90 requested a review from a team as a code owner May 4, 2023 13:28
@arajasek arajasek merged commit 1c1a28e into master May 4, 2023
89 of 92 checks passed
@arajasek arajasek deleted the fix/beneficiary-clearer-args-input branch May 4, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants