feat: deflake msgindex_test.go #10826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
approved these changes
May 4, 2023
Comment on lines
+301
to
+307
| func waitForCoalescerAfterLastEvent() { | ||
| // It can take up to CoalesceMinDelay for the coalescer timer to fire after the last event. | ||
| // When the timer fires, it can wait up to CoalesceMinDelay again for more events. | ||
| // Therefore the total wait is 2 * CoalesceMinDelay. | ||
| // Then we wait another second for the listener (the index) to actually process events. | ||
| time.Sleep(2*CoalesceMinDelay + time.Second) | ||
| } |
There was a problem hiding this comment.
Might be worth adding to the itest kit? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
This test has been observed to fail unpredictably (eg. here). The issue is that we don't necessarily wait long enough for changes in the Coalescer to be dispatched before polling the index, which leads to failure.
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps