Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests: Use mutex-wrapped datastore in storage tests #10846

Merged
merged 1 commit into from
May 9, 2023

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented May 9, 2023

Related Issues

Should fix a flake from https://app.circleci.com/pipelines/github/filecoin-project/lotus/28667/workflows/ae7a8156-78d0-48c2-852f-e203ea10e251/jobs/966677

Proposed Changes

Additional Info

fatal error: concurrent map read and map write

goroutine 103 [running]:
github.com/ipfs/go-datastore.(*MapDatastore).Has(0xc000046420?, {0x37e6f28?, 0xc00054be20?}, {{0xc00003a420?, 0x2c?}})
	/home/circleci/go/pkg/mod/github.com/ipfs/go-datastore@v0.6.0/basic_ds.go:51 +0x2e
github.com/filecoin-project/go-statestore.(*StoredState).End(0xc00054be68)
	/home/circleci/go/pkg/mod/github.com/filecoin-project/go-statestore@v0.2.0/state.go:20 +0x43
github.com/filecoin-project/lotus/storage/sealer.(*workerCallTracker).onReturned(0x37d9f58?, {{0x3e8, 0x1}, {0xce, 0xc, 0x8, 0x2b, 0x5a, 0x7a, 0x4c, ...}})
	/home/circleci/lotus/storage/sealer/worker_calltracker.go:55 +0x8a
github.com/filecoin-project/lotus/storage/sealer.(*LocalWorker).asyncCall.func1()
	/home/circleci/lotus/storage/sealer/worker_local.go:300 +0x3f7
created by github.com/filecoin-project/lotus/storage/sealer.(*LocalWorker).asyncCall
	/home/circleci/lotus/storage/sealer/worker_local.go:275 +0x34f

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner May 9, 2023 16:06
@magik6k magik6k force-pushed the fix/tests-storage-unit-syncds branch from 0c4bc69 to 2f469c2 Compare May 9, 2023 16:06
@arajasek arajasek enabled auto-merge May 9, 2023 16:14
@arajasek arajasek merged commit ff8d81d into master May 9, 2023
86 of 92 checks passed
@arajasek arajasek deleted the fix/tests-storage-unit-syncds branch May 9, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants