Upgrade urfave dependency which now supports DisableSliceFlagSeparato…

[fridrik01]

Context
In #10761 we added a new RPC benchmarking tool which parses options from terminal to build up RPC requests. However, our current urfave version does not support parsing cli options if they have a comma (,) in them. This was however added by urfave a few months ago by introducing a new flag DisableSliceFlagSeparator.

Unfortunately, upgrading the urfave dependency introduced regressions in how it generated --help output, especially for commands with subcategories, where the subcategory was not included in the help output.

• I created a new urfave issue that reported this as bug (Newer version of urfave do not display categories for subcommands urfave/cli#1734)
• Urfave fixed the bug (Fix:(issue_1734) Show categories for subcommands urfave/cli#1735)
• Urfave merged the fix in 2.25.4 (https://github.com/urfave/cli/releases/tag/v2.25.4)

NOTE that are have been some changes still in how urfave generates --help output from our previous version (2.16.3) but these look ok to me

Test plan
Observed that lotus-bench rpc now works when passing it options with comma:

lotus-bench rpc --duration=3s --method='eth_getTransactionCount:10:2000:["0xd4c70007F3F502f212c7e6794b94C06F36173B36", "latest"]
[eth_getTransactionCount]:
- Options:
  - concurrency: 10
  - params: ["0xd4c70007F3F502f212c7e6794b94C06F36173B36", "latest"]
  - qps: 2000
- Total Requests: 5987
- Total Duration: 3004ms
- Requests/sec: 1992.487708
- Avg latency: 0ms
- Median latency: 0ms
- Latency distribution:
    10.00% in 0ms
    50.00% in 0ms
    90.00% in 0ms
    95.00% in 0ms
    99.00% in 0ms
    99.90% in 11ms
- Histogram:
     0-1ms|  5958|################################################################################################### (99.52%)
     1-2ms|     3| (0.05%)
     2-3ms|     3| (0.05%)
     3-4ms|     5| (0.08%)
     4-5ms|     5| (0.08%)
     5-6ms|     3| (0.05%)
     6-7ms|     0| (0.00%)
     7-8ms|     0| (0.00%)
     8-9ms|     1| (0.02%)
    9-13ms|     9| (0.15%)
- Status codes:
    [200]: 5987
- Errors (top 10):
    [nil]: 5987

[ZenGround0]

Looks like this needs go mod tidy

Taking a look now.

Nice work pushing the fix through the dependency.

[ZenGround0]

Not a blocker but is it possible to restrict this only to the rpcCmd? As I understand it we only want this to apply to that one subcommand.

[fridrik01]

This option is only available on the cli app and not for individual subcommands.