Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sealing: Use only non-assigned deals when selecting snap sectors #11002

Merged
merged 1 commit into from Jun 28, 2023

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jun 23, 2023

Related Issues

Likely fixes #10914
Thanks to added logging in #10915

Proposed Changes

The sealing pipeline keeps pending piece references for a while after deals are assigned/added to sectors. When selecting what sector to upgrade, we calculate a list which says "at Y epoch there are X deals waiting to be inserted into a sector". That logic only cares about deals/pieces which weren't added/assigned to any sector, which we didn't check, causing us to potentially select sectors which couldn't accept any deals, which would cause the pipeline to fill up with waiting sectors, just waiting for a timeout..

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner June 23, 2023 16:46
@arajasek arajasek merged commit 30a9f63 into master Jun 28, 2023
93 checks passed
@arajasek arajasek deleted the feat/dealbounds-calc branch June 28, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lotus Assigns SnapDealsWaitDeals Status to Sectors with +90 Days Duration Causing Snap Failure
3 participants