Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: chain/actors: Use type proxies instead of versioned GST imports #11216

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Aug 29, 2023

Related Issues

Started doing as part of #11125 when weaving through the new nv21 DDO types through the Piece/Sector sealing pipeline, but the rabbit hole turned into a small cave system

Proposed Changes

  • Use type aliases in chain/actors/builtin instead of importing versioned go-state-types structs all over the place
  • This in principle should allow us to easily switch from importing v9 types everywhere to higher versions much more easily
  • But not quite yet with just this PR, though it gets us much closer to less pain

Additional Info

There should be zero logic changes as the effect of this PR, just swapping how we import/use actor types in the codebase.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner August 29, 2023 13:32
@magik6k magik6k changed the base branch from master to feat/nv21 August 29, 2023 13:33
@magik6k magik6k merged commit d3b31d5 into feat/nv21 Aug 29, 2023
93 checks passed
@magik6k magik6k deleted the chore/actor-type-proxies branch August 29, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants