Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli: Wrap error in wallet sign #11273

Merged
merged 2 commits into from
Sep 21, 2023
Merged

fix: cli: Wrap error in wallet sign #11273

merged 2 commits into from
Sep 21, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Sep 19, 2023

Related Issues

Closes: #7919

Proposed Changes

Wrap error when a msig is trying to sign a msg, explaining that msig messages needs to propose & approve.

Additional Info

When trying to sign with a msig, error is now wrapped as:

lotus wallet sign t2pgqal7cetyqb6thbkb6s4nlbx3to5mm4azc43si 3fa85f6457174562b3fc2c963f66afa6
ERROR: multisig is an actor account that doesn’t have keys to sign transactions. To send a message with a multisig, signers of the multisig need to propose and approve transactions.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Wrap error when a msig is trying to sign a msg, explaining that msigs needs to propose & approve.
@rjan90 rjan90 requested a review from a team as a code owner September 19, 2023 08:59
cli/wallet.go Outdated Show resolved Hide resolved
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
@arajasek arajasek merged commit 70cb445 into master Sep 21, 2023
87 checks passed
@arajasek arajasek deleted the fix/wrap-sign-error branch September 21, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: failed to resolve ID address: %!w(address.Address={})
3 participants