Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config: Update ColdStoreType comments #11274

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Sep 19, 2023

Proposed Changes

The comments in the Splitstore config.toml says "messages" are the default, while it is actually the "discard" mode. This PR updates the comments to make it correct.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Update comments to say that "discard" is the default mode in SplitStore.
@rjan90 rjan90 requested a review from a team as a code owner September 19, 2023 10:35
Make gen
Remove double default
@magik6k magik6k merged commit a8d693a into master Sep 22, 2023
83 of 87 checks passed
@magik6k magik6k deleted the fix/update-splitstore-config-comments branch September 22, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants