Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add .vscode to gitignore #11275

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix: Add .vscode to gitignore #11275

merged 1 commit into from
Sep 21, 2023

Conversation

fridrik01
Copy link
Contributor

Related Issues

None

Proposed Changes

Although we can configure this globally, we should just always ignore .vscode directory to make sure it doesn't get accidentally included in future PRs

Additional Info

None

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@fridrik01 fridrik01 marked this pull request as ready for review September 19, 2023 11:02
@fridrik01 fridrik01 requested a review from a team as a code owner September 19, 2023 11:02
@magik6k magik6k merged commit 30e4259 into master Sep 21, 2023
86 of 87 checks passed
@magik6k magik6k deleted the add-vscode-to-gitignore branch September 21, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants