Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: miner: defensive check for equivocation #11321

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

arajasek
Copy link
Contributor

Related Issues

@Stebalien was concerned that this could cause miners to fail to produce blocks when if they see a reorg of height > 1 partway through the mining loop. The issue is that if the tipset at the height of the base's parent changes, the intersection between old and new base MUST be null, and the miner will fail.

Proposed Changes

Weaken the check against equivocation a little -- if the intersection is null, just use the old base (even though it risks "allowing" some equivocation.).

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner October 10, 2023 14:17
@Stebalien
Copy link
Member

I think we need to go with this for now, but we'll need to fix it properly later.

@Stebalien Stebalien added this to the Network v21 milestone Oct 10, 2023
@arajasek arajasek merged commit 2b36722 into master Oct 11, 2023
87 checks passed
@arajasek arajasek deleted the asr/tweak-equivocation branch October 11, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants