Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alert: Check UDPbuffer-size #11360

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix: alert: Check UDPbuffer-size #11360

merged 2 commits into from
Oct 30, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Oct 30, 2023

Related Issues

Closes #11289

Proposed Changes

In Lotus today, you will encounter this error on startup if the UDP Buffer size is lower than 2048 KiB.

2023/10/28 11:53:26 failed to sufficiently increase receive buffer size (was: 208 kiB, wanted: 2048 kiB, got: 416 kiB). See https://github.com/quic-go/quic-go/wiki/UDP-Buffer-Sizes for details.

This PR adds it as an alert in the lotus info system:

lotus log alerts
active   process:udp-buffer-size
         last raised at 2023-10-30 05:46:32.415 -0400 EDT; reason: {"current_size":212992,"help":"See https://github.com/quic-go/quic-go/wiki/UDP-Buffer-Sizes for details.","message":"UDP buffer size is low","wanted_size":2097152}

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Raise alert if UDP-buffer size is not high enough
@rjan90 rjan90 requested a review from a team as a code owner October 30, 2023 09:48
Added error handling for the Close() method calls in the CheckUDPBufferSize function to satisfy linting rules and improve error logging.
@magik6k magik6k merged commit 3720e79 into master Oct 30, 2023
87 checks passed
@magik6k magik6k deleted the fix/add-udp-alert branch October 30, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to Docs recommendation to increase UDP Buffer Sizes
2 participants