Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Drop the raft-cluster experiment #11468

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Nov 29, 2023

Related Issues

Proposed Changes

This PR removes raft cluster support entirely. This feature has never graduated beyond an experiment, had poor UX (e.g. no way to manage a running cluster, so it didn't even provide HA), and pulled in a lot of heavy dependencies. This implementation also is only useful in clusters which want to do message signing on chain nodes, and in most cases where running a node cluster is warranted, signing anything on nodes which are high maintenance chain syncing nodes is at least a bad practice.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from a team as a code owner November 29, 2023 17:00
@Stebalien
Copy link
Member

TODO: Add this to the release notes.

@snadrus snadrus merged commit 0c7037b into master Jan 9, 2024
88 checks passed
@snadrus snadrus deleted the misc/drop-raft-experiment branch January 9, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants