fix: eth: decode as actor creation iff "to" is the EAM #11520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we weren't checking the "to" address. I've also re-ordered the operations in this function to make it easier to reason about them. It'll have a slight runtime cost (we _always_ ABI-encode the parameters, then throw away the result if it turns out we're actually dealing with an Ethereum transaction), but it's _much_ simpler.
Stebalien
force-pushed
the
steb/fix-eth-native-tx
branch
from
274e6fa
to
a35af09
Compare
fridrik01
approved these changes
Dec 14, 2023
Comment on lines
-552
to
-553
| // Yeah, we're going to ignore errors here because the user can send whatever they | ||
| // want and may send garbage. |
There was a problem hiding this comment.
nit: this comment was somewhat useful as to why we are ignoring decodePayload errors
There was a problem hiding this comment.
Fair. I've expanded the replacement comment to explain that the user can send garbage.
rjan90
pushed a commit
that referenced
this pull request
Dec 15, 2023
Previously, we weren't checking the "to" address. I've also re-ordered the operations in this function to make it easier to reason about them. It'll have a slight runtime cost (we _always_ ABI-encode the parameters, then throw away the result if it turns out we're actually dealing with an Ethereum transaction), but it's _much_ simpler.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Decode messages as contract deployments if and only if the "to" address is the EAM.
Previously, we weren't checking the "to" address. I've also re-ordered the operations in this function to make it easier to reason about them. It'll have a slight runtime cost (we always ABI-encode the parameters, then throw away the result if it turns out we're actually dealing with an Ethereum transaction), but it's much simpler.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps